feat(specs): rename composition to composition-full (private) and add composition (public) #4357

e-krebs · 2025-01-14T10:41:59Z

🧭 What and Why

🎟 JIRA Ticket: EMERCH-1832 https://algolia.atlassian.net/browse/DI-3391

Changes included:

rename composition to composition-full (this is the existing private Package)
- breaking change: the exported function (and its type) changes from createCompositionClient to createCompositionFullClient
create new composition specs (this is the public Package)

🧪 Test

…ition (public)

algolia-bot · 2025-01-14T10:42:14Z

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name	Link
🪓 Triggered by	`15c5f6d218242341aede5b3dfc884af07d2453a2`
🍃 Generated commit	`9785b90f48de5ec4f7ae427ce80b827f090f862f`
🌲 Generated branch	`generated/feat/composition-public-package`

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language	Req/s
go	1668
javascript	1614
php	1452
csharp	1233
java	1113
python	1104
ruby	862
swift	750

shortcuts · 2025-01-14T12:25:53Z

config/clients.config.json

@@ -163,7 +174,7 @@
        "output": "clients/algoliasearch-client-javascript/packages/client-search"
      },
      {
-        "name": "composition",
+        "name": "composition-full",


wdyt of admin instead of full?

those extra endpoints are clearly not for admin,
they will be public eventually, just not now.
so 😕

ok make sense so at some point the composition client will be used in favor of the full right?

that's what I expect, yes

shortcuts · 2025-01-16T22:22:00Z

kotlin: ambiguity in imports for requestbody, either rename or import the package directly

…ic-package

… composition (public) (#4357) (generated) [skip ci] Co-authored-by: Emmanuel Krebs <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>

… composition (public) (generated) algolia/api-clients-automation#4357 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Emmanuel Krebs <[email protected]> Co-authored-by: shortcuts <[email protected]> Co-authored-by: Pierre Millot <[email protected]>

feat: rename composition to composition-full (private) and add compos…

6b11b8c

…ition (public)

e-krebs self-assigned this Jan 14, 2025

shortcuts added 2 commits January 14, 2025 12:16

fix: add custom paths

d9a9d10

fix: skip custom tests

93ef4eb

shortcuts force-pushed the feat/composition-public-package branch from a1dbe5f to 93ef4eb Compare January 14, 2025 12:21

fix: algoliasearch cts

f090046

shortcuts changed the title ~~feat(specs): rename composition to composition-full (private) and add composition (public)~~ feat(specs): rename composition to composition-full (private) and add composition (public) [skip-bc] Jan 14, 2025

shortcuts added 2 commits January 14, 2025 13:35

fix: cts

46fbfee

fix: algoliasearch

6b961b0

shortcuts reviewed Jan 14, 2025

View reviewed changes

shortcuts and others added 9 commits January 14, 2025 14:24

fix: javascript playground

ef94e82

fix: swift duplicates

ab3896f

fix: playground

899dc05

fix: generate composition tests for JS

6b777d6

fix: more fix for javascript

5788633

fix: more JS fix

7f13d4d

fix: JS snippets generations

48f4825

fix: remove test that doesn't make sense without custom methods

afb8e9f

fix: dart generation

fede5cb

millotp changed the title ~~feat(specs): rename composition to composition-full (private) and add composition (public) [skip-bc]~~ feat(specs): rename composition to composition-full (private) and add composition (public) Jan 16, 2025

shortcuts added 8 commits January 16, 2025 23:27

fix: dart

c45a50a

Merge branch 'main' into feat/composition-public-package

57c1b79

fix: kotlin

f95b503

fix: templates

c275a13

fix: is variable

22a28d3

fix: imports

606cbb6

fix: javascript tests

bae83d0

fix: Full naming

c44e17e

shortcuts and others added 10 commits January 20, 2025 08:49

fix: kotlin tests

9178823

fix: javascript

ad0fbcf

fix: JS build

5879c87

fix: JS playground

af4bf96

fix: JS CTS

ca02d67

fix: kotlin CTS

45066ed

fix generics

1603ad7

dont gen for swift

7ec686c

Merge remote-tracking branch 'origin/main' into feat/composition-publ…

04815d4

…ic-package

rollback a bit

660bea5

millotp approved these changes Jan 22, 2025

View reviewed changes

millotp marked this pull request as ready for review January 22, 2025 08:17

millotp requested a review from a team as a code owner January 22, 2025 08:17

millotp requested review from morganleroi and Fluf22 January 22, 2025 08:17

millotp merged commit 83f188d into main Jan 22, 2025
28 checks passed

millotp deleted the feat/composition-public-package branch January 22, 2025 08:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(specs): rename composition to composition-full (private) and add composition (public) #4357

feat(specs): rename composition to composition-full (private) and add composition (public) #4357

e-krebs commented Jan 14, 2025 •

edited by shortcuts

Loading

algolia-bot commented Jan 14, 2025 •

edited

Loading

shortcuts Jan 14, 2025

e-krebs Jan 14, 2025

shortcuts Jan 14, 2025

e-krebs Jan 14, 2025

shortcuts commented Jan 16, 2025

feat(specs): rename composition to composition-full (private) and add composition (public) #4357

feat(specs): rename composition to composition-full (private) and add composition (public) #4357

Conversation

e-krebs commented Jan 14, 2025 • edited by shortcuts Loading

🧭 What and Why

Changes included:

🧪 Test

algolia-bot commented Jan 14, 2025 • edited Loading

💥 Breaking changes detected !!

✔️ Code generated!

shortcuts Jan 14, 2025

Choose a reason for hiding this comment

e-krebs Jan 14, 2025

Choose a reason for hiding this comment

shortcuts Jan 14, 2025

Choose a reason for hiding this comment

e-krebs Jan 14, 2025

Choose a reason for hiding this comment

shortcuts commented Jan 16, 2025

e-krebs commented Jan 14, 2025 •

edited by shortcuts

Loading

algolia-bot commented Jan 14, 2025 •

edited

Loading