Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies and Comments #303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Dependencies and Comments #303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c893e
Update Dependencies and Comments
irregularised Sep 6, 2024
bae09b3
Made comments less redundant.
irregularised Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go.work.sum
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to check the comparability of the existing dependencies first as I still have some open PRs from dependabot to review.

Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpE
github.com/tinylib/msgp v1.1.8/go.mod h1:qkpG+2ldGg4xRFmx+jfTvZPxfGFhi64BcnL9vkCm/Tw=
github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
golang.org/x/crypto v0.14.0/go.mod h1:MVFd36DqK4CsrnJYDkBA3VC4m2GkXAM0PvzMCn4JQf4=
golang.org/x/crypto v0.21.0/go.mod h1:0BP7YvVV9gBbVKyeTG0Gyn+gZm94bibOW5BjDEYAOMs=
golang.org/x/term v0.13.0/go.mod h1:LTmsnFJwVN6bCy1rVCoS+qHT1HhALEFxKncY3WNNh4U=
golang.org/x/term v0.18.0/go.mod h1:ILwASektA3OnRv7amZ1xhE/KTR+u50pbXfZ03+6Nx58=
golang.org/x/text v0.8.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
2 changes: 2 additions & 0 deletions scraper/pkg/tripadvisor/tripadvisor.go
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the newline as it's not necessary. Function comments should with start with the function name.

Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ func ParseURL(url string, locationType string) (locationID uint32, locationName
}
}

// Puts the current reviews into a JSON file
func WriteReviewsToJSONFile(reviews []Review, location Location, fileHandle *os.File) error {
feedback := Feedback{
Location: location,
Expand All @@ -257,4 +258,5 @@ func SortReviewsByDate(reviews []Review) {
jTime, _ := time.Parse(layout, reviews[j].CreatedDate)
return iTime.After(jTime)
})

}