Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GLSurfaceView with GLRenderer and AndroidExternalSurface #1908

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alexvanyo
Copy link
Owner

@alexvanyo alexvanyo commented Jul 18, 2024

Fixes #1838

Current issues:

  • Crashes when rotating on physical device: https://issuetracker.google.com/382607450
    2024-10-10 10:27:50.720 27061-27158 AndroidRuntime          com.alexvanyo.composelife            
    E  FATAL EXCEPTION: GLThread
                                                                                                        
    Process: com.alexvanyo.composelife, PID: 27061
                                                                                                      
    java.lang.IllegalStateException: OpenGL framebuffer error: 33305
                                                                                                      	 
    at B1.o.d(SourceFile:558)
                                                                                                      	 
    at B1.m.run(SourceFile:38)
                                                                                                      	 
    at android.os.Handler.handleCallback(Handler.java:959)
                                                                                                      	 
    at android.os.Handler.dispatchMessage(Handler.java:100)
                                                                                                      	 
    at android.os.Looper.loopOnce(Looper.java:232)
                                                                                                      	 
    at android.os.Looper.loop(Looper.java:317)
                                                                                                      	 
    at android.os.HandlerThread.run(HandlerThread.java:85)
    

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes missing coverage. Please review.

Project coverage is 62.08%. Comparing base (9145b31) to head (9336c29).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...composelife/ui/cells/OpenGLNonInteractableCells.kt 0.00% 81 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1908      +/-   ##
============================================
- Coverage     62.22%   62.08%   -0.14%     
  Complexity      517      517              
============================================
  Files           237      237              
  Lines         12499    12526      +27     
  Branches       2217     2220       +3     
============================================
  Hits           7777     7777              
- Misses         3559     3586      +27     
  Partials       1163     1163              
Flag Coverage Δ
21 62.08% <0.00%> (-0.14%) ⬇️
35 62.07% <0.00%> (-0.14%) ⬇️
unit 62.08% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexvanyo alexvanyo changed the title Replace GLSurfaceview with GLRenderer and AndroidExternalSurface Replace GLSurfaceView with GLRenderer and AndroidExternalSurface Aug 12, 2024
@alexvanyo alexvanyo added the android Specific to Android label Sep 23, 2024
@alexvanyo alexvanyo force-pushed the av/glrenderer branch 4 times, most recently from c90337b to 8f008ea Compare September 25, 2024 02:00
@alexvanyo alexvanyo force-pushed the av/glrenderer branch 4 times, most recently from d9b4c26 to 4aa578b Compare October 10, 2024 17:19
@alexvanyo alexvanyo force-pushed the av/glrenderer branch 5 times, most recently from 989bdb2 to 25520d2 Compare January 17, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Specific to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace AndroidView wrapping GLSurfaceView with AndroidExternalSurface and GLRenderer
1 participant