Attempt to wire up Brushless settings #79
Conversation
| for await (const d of ebbs(device, model)) { | ||
| ebb = d; | ||
| broadcast({c: "dev", p: {path: ebb ? /*ebb.port.path*/"/dev/XXX" : null}}); | ||
| } |
There was a problem hiding this comment.
this seems fragile - all EBBs need to be of the same model :/
|
Oh, I'm sorry I didn't see this! I was working locally and ended up doing many of the same things, then pushed them last night. Let me take a look at what you've done. Thanks for the PR! |
|
It's taking me a bit of time to test since I'm on a pi zero and need to compile a modern nodejs first - will undraft after testing |
|
OK, so it looks like you and I ended up basically doing the same thing. Slightly different terminology but the same code patterns. |
* (fix): Switch React API from v17 to v18 * Update src/ui.tsx --------- Co-authored-by: Jeremy Rose <[email protected]>
* chore(deps): update dependency ts-loader to v9 * update package-lock --------- Co-authored-by: Jeremy Rose <[email protected]>
* chore(deps): update dependency rimraf to v5 * update package-lock --------- Co-authored-by: Jeremy Rose <[email protected]>
* chore(deps): update dependency worker-loader to v3 * update package-lock --------- Co-authored-by: Jeremy Rose <[email protected]>
* chore(deps): update dependency file-loader to v6 * update package-lock * revert * update package-lock --------- Co-authored-by: Jeremy Rose <[email protected]>
* chore(deps): update dependency @types/node to 14.x * Specifiy minimum node version
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Ruddick <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit 4d4fe36.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2#70) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
I'm going to rebase on top of (45ec256 was the last commit in my |
|
i have to split my changes into 2 branches one that is brushless specific, and one that is raspberry pi zero specific. |
|
FYI this old patchset is working fine on my axidraw with brushless upgrade - lmk if you want me to change anything or abandon it or whatever. Its gotten a bit messy so I can rebase and re-apply, or wait for your changes to be ready to test. |
What do you mean by "old patchset" - my branch, or yours? I don't particularly care which implementation we use. Mine works on real hardware with one exception - it smashes the pen to the limit stop at the end of the drawing. What numbers are you using here? Lines 120 to 121 in f061831 |
|
Oh I just meant that the changes in |
|
I was using as you were, but nornagon#136 says it should be or with the strong spring: |
No description provided.