fix multiple connects #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrudd2
force-pushed
the
fix-multiple-connects
branch
from
9236b36 to
fb916c7
Compare
alexrudd2
force-pushed
the
fix-multiple-connects
branch
from
fb916c7 to
49a07d3
Compare
|
|
jedahan
approved these changes
Oct 14, 2023
|
Does it improve the situation for you if you cherry-pick to |
|
Testing on top of brushless-v4 now |
(oops, didn't mean to close). OK, great! I'm hoping this solves the stuttering for you, and hope you saw #114. It's my attempt to consolidate the brushless changes (without a bunch of formatting noise) |
|
Plotting is much smoother now. Pause and cancel still do not work in the middle of a plot, but that we can solve as a separate issue |
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event listeners for drag-n-drop don't need to be called multiple times, so pass
[]as the second argument touseEffect.The event listeners for the driver (probably) don't need to be called multiple times, so do it only for WebSerial (revert, this breaks ping/pongIS_WEB==true).Wrap the
SaxiDriver.connect()call in a flag so it doesn't get called multiple times inRoot().