-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update uri to omit deployment ids for assistant and thread paths #431
base: main
Are you sure you want to change the base?
fix: update uri to omit deployment ids for assistant and thread paths #431
Conversation
Co-authored-by: Bryan Morrow <[email protected]>
@alexrudall Any status on this? |
Thanks for patience, I need to get access to Azure OpenAI so I can test this & other Azure PRs - hope to within next week or 2 |
@alexrudall Any updates? |
@alexrudall fwiw, I just tested this on both the API versions listed on the Azure page and confirmed this fix works as expected |
@alexrudall - if you want, we could donate a key to you for this testing if it is blocking you. We really need this merged. |
Hi @nhorton, @emilong , @CarterBland, thanks for this PR & for your patience. I'm considering releasing a 'pro' version of ruby-openai that would allow me to prioritise testing & merging features like this before adding to the free version at a later date - similar to sidekiq-pro & graphql-pro. I would also offer ongoing support, and other improvements including performance enhancement. Would your use cases justify this? Likely cost $299/year or similar. Again, thank you for your patience and apologies that I haven't been able to prioritise this PR yet. |
Sure - we would be happy to do that. |
Thanks a lot @nhorton! I'll try to put that together this week and respond here. |
The fork by @CarterBland works for me. When will this be merged? |
Summary:
Solves Assistants Support for Azure's new API version 2024-02-15-preview #430
Tested in my own local application and the URI with the deployment id omitted unblocks the whole process from creating an assistant, thread, and message.
Solution:
Support assistants API by removing the deployment id for certain paths
Example:
https://custom-domain.openai.azure.com/openai/deployments/gpt-35-turbo/assistants
to
https://custom-domain.openai.azure.com/openai/assistants
All Submissions: