Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix save_mapping and load_mapping utils #54

Merged
merged 10 commits into from
Jul 19, 2024

Conversation

pbarbarant
Copy link
Collaborator

@pbarbarant pbarbarant commented May 27, 2024

Closes #42, closes #55. save_mapping now dumps the weights on the cpu before saving and the user has the choice to pass a device when using load_mapping.

@pbarbarant pbarbarant changed the title [FIX] [FIX] Fix save_mapping and load_mapping utils May 27, 2024
@pbarbarant pbarbarant requested a review from bthirion July 19, 2024 15:35
Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbarbarant pbarbarant merged commit b1063cd into alexisthual:main Jul 19, 2024
7 checks passed
@pbarbarant pbarbarant deleted the fix/storing-mapping branch October 13, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Coarse-to-fine test fails on GPU [BUG] Remove res["pi"].detach().cpu()
2 participants