Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-generator): fileCounts not getting emitted into json #141

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

ProjectBarks
Copy link
Contributor

Background

According to this report #72 fileCounts was not getting outputted into the JSON type due to the input type to the serializer being JSON. The reasoning for this Maps in javascript when serialized through JSON.stringify are converted into {}.

Solution

Run JSON.fromEntries on fileCounts before serializing. Also, added a unit test to ensure the output works and prevent future regressions.

@alexcanessa
Copy link
Owner

Amazing @ProjectBarks, thanks so much :)

@alexcanessa alexcanessa merged commit 9ef7ea6 into alexcanessa:main Feb 12, 2024
1 check passed
@alexcanessa
Copy link
Owner

@all-contributors add @ProjectBarks for code

Copy link
Contributor

@alexcanessa

I've put up a pull request to add @ProjectBarks! 🎉

@alexcanessa
Copy link
Owner

@ProjectBarks this has been published with 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants