-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce side bearings on single quote #351
base: master
Are you sure you want to change the base?
Conversation
Do the changes also apply to e.g. the Unicode Character 'RIGHT SINGLE QUOTATION MARK' (U+2019)? |
Nope not yet. And that's egg on my face because that's what the original issue was about! Here is a slightly more advanced test case that covers U+2019 as well: SILE test code
Full test output: quote.pdf Clearly not addressed yet... |
Yes. Actually all the other weights and styles need adjusting, but I was putting it off since I'm not ready to merge this (which will be a major breaking change). I'll do it eventually and probably keep it along with some other big changes in a devel branch for a while before enough comes together to do a breaking release. |
Closes #323.
This currently a WIP, but when it does land it will be a significant change to metrics, so I will probably delay merging this until after a few small fixes hit and a minor dot release happens first.
test code
@rriemann What do you think of this? (Besides the preview above you can download artifacts from the Actions tab of this PR to test for yourself.)