cmd/chrome: go mod tidy #936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run go mod tidy on cmd/chroma using go1.22.0 Also add a couple of steps to CI to run as part of CI, and enforce that the module be tidy by ensuring the git working directory is not dirty at the end of a workflow. We use this approach in all of the CUE project workflows: https://github.com/cue-lang/cue/blob/5b4a5819b55593357486cba3c7fc0d0a1853f031/.github/workflows/trybot.yml#L202-L203
myitcv
force-pushed
the
tidy_cmd_chroma
branch
from
eea345f to
93f30e6
Compare
|
In an earlier commit of this PR I intentionally left out the changes to https://github.com/alecthomas/chroma/actions/runs/8052585442/job/21993047886 |
|
I appreciate the PR, but this is unnecessary on a project of this size. This just adds unnecessary friction. What I typically prefer if I want to enforce something similar is to automatically commit the changes. As long as everything builds correctly, I'm fine with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run go mod tidy on cmd/chroma using go1.22.0
Also add a couple of steps to CI to run as part of CI, and enforce that the module be tidy by ensuring the git working directory is not dirty at the end of a workflow.
We use this approach in all of the CUE project workflows:
https://github.com/cue-lang/cue/blob/5b4a5819b55593357486cba3c7fc0d0a1853f031/.github/workflows/trybot.yml#L202-L203