Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ocaml): support multistring #1035

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 7, 2025

Add support for quoted OCaml multistrings.
The grammar is specified in https://ocaml.org/manual/5.2/lex.html#sss:stringliterals

{ quoted-string-id | { newline ∣ any-char } | quoted-string-id }
quoted-string-id ::= { a...z ∣ _ }

Added a real-world case (my own bad code) as testdata that has an empty quoted id and a normal quoted id.

Before:
Screen Shot 2025-01-07 at 05 43 19

After:
Screen Shot 2025-01-07 at 05 42 12

Support quoted OCaml multistrings.
The grammar is specified in https://ocaml.org/manual/5.2/lex.html#sss:stringliterals
Added a real-world case (my own bad code) as testdata that has an empty
quoted id and a normal quoted id.
@alecthomas alecthomas merged commit d829579 into alecthomas:master Jan 7, 2025
2 checks passed
@alecthomas
Copy link
Owner

Thanks very much!

@Gusted Gusted deleted the ocaml-multistring branch January 7, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants