Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signature aggregators #980

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dancoombs
Copy link
Collaborator

Closes #219

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 65.71709% with 349 lines in your changes missing coverage. Please review.

Project coverage is 59.38%. Comparing base (6c2e4ef) to head (765b775).

Files with missing lines Patch % Lines
crates/types/src/user_operation/mod.rs 48.00% 52 Missing ⚠️
crates/aggregators/bls/src/bls.rs 0.00% 50 Missing ⚠️
crates/types/src/user_operation/v0_7.rs 68.85% 38 Missing ⚠️
crates/pool/src/server/remote/protos.rs 0.00% 17 Missing ⚠️
crates/pool/src/server/remote/error.rs 0.00% 16 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 16 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 16 Missing ⚠️
bin/rundler/src/cli/aggregator.rs 0.00% 15 Missing ⚠️
crates/builder/src/bundle_proposer.rs 88.52% 14 Missing ⚠️
crates/provider/src/alloy/da/local/nitro.rs 0.00% 13 Missing ⚠️
... and 19 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/emit.rs 36.00% <ø> (ø)
crates/pool/src/mempool/pool.rs 96.99% <100.00%> (+0.01%) ⬆️
crates/pool/src/mempool/uo_pool.rs 92.57% <100.00%> (+0.51%) ⬆️
crates/provider/src/traits/da.rs 50.00% <ø> (ø)
crates/provider/src/traits/entry_point.rs 80.00% <ø> (-20.00%) ⬇️
crates/provider/src/traits/test_utils.rs 100.00% <100.00%> (ø)
crates/sim/src/estimation/mod.rs 85.71% <ø> (ø)
crates/sim/src/precheck.rs 76.30% <100.00%> (+0.12%) ⬆️
crates/sim/src/simulation/mod.rs 43.75% <ø> (-3.31%) ⬇️
crates/sim/src/simulation/v0_6/context.rs 68.02% <100.00%> (+0.11%) ⬆️
... and 34 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
unit-tests 59.38% <65.71%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 65.64% <88.52%> (+0.03%) ⬆️
dev ∅ <ø> (∅)
pool 67.34% <79.11%> (+0.39%) ⬆️
provider 19.10% <5.19%> (-0.40%) ⬇️
rpc 26.38% <12.50%> (-0.05%) ⬇️
sim 77.42% <80.68%> (+0.38%) ⬆️
tasks ∅ <ø> (∅)
types 68.80% <75.00%> (+1.53%) ⬆️
utils 30.06% <ø> (ø)

@dancoombs dancoombs force-pushed the danc/signature-aggregators branch from d8a6985 to 600e133 Compare January 30, 2025 00:22
@dancoombs dancoombs force-pushed the danc/signature-aggregators branch 3 times, most recently from 14fceb7 to 3d1ba28 Compare January 30, 2025 13:58
@dancoombs dancoombs force-pushed the danc/signature-aggregators branch 4 times, most recently from 314025c to 152b8e7 Compare January 30, 2025 22:03
@dancoombs dancoombs force-pushed the danc/signature-aggregators branch from 152b8e7 to 765b775 Compare January 30, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc/builder: figure out gas estimation for aggregated ops
1 participant