use explicit hint tokens for export marker #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since unary operator processing in external scanner conflicts with export marker, the export marker was made into a non-terminal rule that was also an external symbol, where the sole reason for the external symbol was to allow the unary operator handler in the external parser know that the marker `*` is meant to be a marker and not an unary operator. Recent tree-sitter changes has forbade this particular usage. As such, switch to using a signal token (an optional token that is an external) to let the external scanner know the context it is handling. Ref: #90 (comment) Ref: tree-sitter/tree-sitter#2577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since unary operator processing in external scanner conflicts with export marker, the export marker was made into a non-terminal rule that was also an external symbol, where the sole reason for the external symbol was to allow the unary operator handler in the external parser know that the marker
*is meant to be a marker and not an unary operator.Recent tree-sitter changes has forbade this particular usage. As such, switch to using a signal token (an optional token that is an external) to let the external scanner know the context it is handling.
Ref: #90 (comment)
Ref: tree-sitter/tree-sitter#2577