scanner: rewrite in C #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the tree-sitter project actively discourage C++ scanners, it was clear that we have to adapt our parser to C to maintain interop with future direction of the ecosystem. The logic and code structure of this rewrite is nearly identical to the C++ version. This is intentional to prevent behavior bugs from creeping in, and an overhaul will come at a later date. Right now this code runs with no crashes and seems to work as well as its C++ predecessor. Fixes #44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the tree-sitter project actively discourage C++ scanners, it was clear that we have to adapt our parser to C to maintain interop with future direction of the ecosystem.
The logic and code structure of this rewrite is nearly identical to the C++ version. This is intentional to prevent behavior bugs from creeping in, and an overhaul will come at a later date.
Right now this code runs with no crashes and seems to work as well as its C++ predecessor.
Fixes #44