Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add windows CI for nimskull #102

Merged
merged 1 commit into from
Sep 1, 2024
Merged

ci: add windows CI for nimskull #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,12 @@ jobs:
- target: macos
arch: i386

# TODO: a handful of problems with SSL must be solved before this
# 32-bit OpenSSL is a pain, so skip
- target: windows
arch: i386
compiler:
name: nimskull

name:
${{ matrix.target }} on ${{ matrix.arch }} (${{ matrix.compiler.name }}
${{ matrix.compiler.version }})
Expand Down
12 changes: 6 additions & 6 deletions src/sys/private/paths_windows.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const
ValidSeparatorsImpl = {SeparatorImpl, '/'}

type
PathParseState = enum
PathParseState {.pure.} = enum
Start
MaybeRoot
FoundPrefix
Expand All @@ -22,7 +22,7 @@ type
AtRoot
PathElement

PathState = enum
PathState {.pure.} = enum
UncNeedHost
UncNeedShare
AtRoot
Expand Down Expand Up @@ -154,11 +154,11 @@ template joinImpl() {.dirty.} =
else:
discard "This is a DOS drive"
of UncNeedShare:
state = AtRoot
of UncNeedHost, AtRoot:
state = PathState.AtRoot
of UncNeedHost, PathState.AtRoot:
discard "These states cannot be reached from the start"
of Root:
state = AtRoot
state = PathState.AtRoot
else:
state = Normal
break
Expand All @@ -176,7 +176,7 @@ template joinImpl() {.dirty.} =
discard "Nothing to do"

of PreviousDir:
if state == AtRoot:
if state == PathState.AtRoot:
continue

else:
Expand Down
Loading