Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: extent = north_america instead of usa #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kishan-Ved
Copy link
Contributor

@Kishan-Ved Kishan-Ved commented Jan 27, 2025

📝 Description

In the documentation of acquisition functions, extent is set to "usa". However, this is invalid. It leads to the following error:

ValueError                                Traceback (most recent call last)
...
    [871](https://vscode-remote+ssh-002dremote-002b7b22686f73744e616d65223a22426861736b6172227d.vscode-resource.vscode-cdn.net/usr/lib/python3.10/multiprocessing/pool.py:871) if success:
    [872](https://vscode-remote+ssh-002dremote-002b7b22686f73744e616d65223a22426861736b6172227d.vscode-resource.vscode-cdn.net/usr/lib/python3.10/multiprocessing/pool.py:872)     return value
--> [873](https://vscode-remote+ssh-002dremote-002b7b22686f73744e616d65223a22426861736b6172227d.vscode-resource.vscode-cdn.net/usr/lib/python3.10/multiprocessing/pool.py:873) raise value

ValueError: Region usa not in supported list of regions with default bounds. Options are: 'global', 'north_america', 'uk', 'europe'.

Ideally, for the examples given in the notebook in the cells ahead, extent should be set to north_america. I have made the required change. The plots and all outputs of the following cells remains the same.

✅ Checklist before requesting a review

(See the contributing guide for more details on these steps.)

  • I have installed developer dependencies with pip install .[dev] and running pre-commit install (or alternatively, manually running ruff format before commiting)

If changing or adding documentation:

  • docs build successfully (jupyter-book build docs --all) and the changes look good from a manual inspection of the HTML in docs/_build/html/.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant