Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis refactor #36

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Analysis refactor #36

merged 8 commits into from
Jan 7, 2025

Conversation

J-Dymond
Copy link
Collaborator

@J-Dymond J-Dymond commented Jan 6, 2025

Minor refactoring changes, restructuring the analysis code

@J-Dymond J-Dymond requested a review from eddableheath January 6, 2025 14:17
eddableheath
eddableheath requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@eddableheath eddableheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating the other comment, but can you rename fitted_uq_model to fitted_lin_model?

src/arc_spice/analysis/analysis_functions.py Show resolved Hide resolved
@eddableheath eddableheath merged commit 5cbebc1 into 21-analysis-script Jan 7, 2025
5 checks passed
@eddableheath eddableheath deleted the analysis_refactor branch January 7, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddableheath eddableheath eddableheath requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J-Dymond @eddableheath