[14.0] [IMP] sale_configurator_base: Only prevent direct sol edition if product was added by the sale configurator interface #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradoxxxzero
force-pushed
the
14.0-sale_configurator_allow_direct_edit_on_non_configured_sol
branch
from
cea4e39 to
eeb4903
Compare
paradoxxxzero
force-pushed
the
14.0-sale_configurator_allow_direct_edit_on_non_configured_sol
branch
from
eeb4903 to
8eadde0
Compare
paradoxxxzero
force-pushed
the
14.0-sale_configurator_allow_direct_edit_on_non_configured_sol
branch
from
8eadde0 to
6676be7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #42 +/- ##
==========================================
+ Coverage 82.44% 82.46% +0.02%
==========================================
Files 47 47
Lines 826 827 +1
Branches 154 154
==========================================
+ Hits 681 682 +1
Misses 127 127
Partials 18 18 ☔ View full report in Codecov by Sentry. |
mourad-ehm
reviewed
Mar 9, 2023
| <button | ||
| title="This product was not added as configurable" | ||
| icon="fa-ban" | ||
| attrs="{'invisible': ['|', ('state', 'not in', ('draft', 'sent')), '|', ('is_configurable', '=', False), ('is_configured', '=', True)]}" |
There was a problem hiding this comment.
If configurable product was added without using configuring interface, we cant edit it to add option ?
…uct was added by the sale configurator interface
paradoxxxzero
force-pushed
the
14.0-sale_configurator_allow_direct_edit_on_non_configured_sol
branch
from
6676be7 to
0a5093b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.