Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14.0 shopinvader WIP #24

Open
wants to merge 17 commits into
base: 14.0
Choose a base branch
from
Open

14.0 shopinvader WIP #24

wants to merge 17 commits into from

Conversation

sebastienbeau
Copy link
Member

@sebastienbeau sebastienbeau commented Jul 23, 2021 •
edited
Loading

TODO

@sebastienbeau sebastienbeau force-pushed the 14.0-shopinvader branch 4 times, most recently from 0c8bd51 to 48bb1b9 Compare November 10, 2021 00:35
@sebastienbeau sebastienbeau mentioned this pull request Nov 10, 2021
Closed
@sebastienbeau sebastienbeau force-pushed the 14.0-shopinvader branch 3 times, most recently from ea12848 to 2301283 Compare November 15, 2021 22:33
@sebastienbeau sebastienbeau force-pushed the 14.0-shopinvader branch 2 times, most recently from 67c5c0d to e8316e5 Compare March 24, 2022 20:31
@sebastienbeau
Copy link
Member Author

@PierrickBrun j'ai quasi finir de corriger cette PR, (les tests passes en local mais on a un soucis avec les tests de sale_configurator_option quand shopinvader est installé)
Au passage je me suis rendu compte que j'ai perdu ce commit 549b338 mais je sais pas pourquoi tu l'avais fait? (j'ai aucun test qui pète lié à ça)

@sebastienbeau @paradoxxxzero
[IMP] start adding configurator module for shopinavder
62a2bec
@sebastienbeau @paradoxxxzero
[IMP] add categ of option
d382c83
@sebastienbeau @paradoxxxzero
[IMP] refactor code to avoid duplicated code
ae41e2a
@sebastienbeau @paradoxxxzero
[IMP] start adding services (extraction of existing custom)
b6610be
@sebastienbeau @paradoxxxzero
[REF] refactor code and start adding test
c34d271
@sebastienbeau @paradoxxxzero
[IMP] add area API
61e69f6
@sebastienbeau @paradoxxxzero
[REF] refactor code for options
885537d
@sebastienbeau @paradoxxxzero
[ADD] add module shopinvader_sale_configurator_variant
d34ab56
@sebastienbeau @paradoxxxzero
[FIX] fix shopinvader_sale_configurator_variant getting name
1b3bd37
@sebastienbeau @paradoxxxzero
[REF] refactor code to get price info and all option info
7d25528
@sebastienbeau @paradoxxxzero
[FIX] fix shopinvader_sale_configurator_variants
354177a
@sebastienbeau @paradoxxxzero
[FIX] fix perf issue
e968d4a
@sebastienbeau @paradoxxxzero
[IMP] add test to ensure onchange playing to not do any mess
26ed1c0 
See PR #40
sale_configurator_option was adding default option ids when calling product_option_id
this was doing a huge mess when the user log in (option was convert to normal line)
the fix is done their but by security we keep a test here
@sebastienbeau @paradoxxxzero
[FIX] fix warnings
9133487
@sebastienbeau @paradoxxxzero
shopinvader_sale_configurator_variant: add test
784b624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paradoxxxzero paradoxxxzero paradoxxxzero left review comments

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastienbeau @paradoxxxzero @github-grap-bot