Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split newlines only at Python universal newlines (LF, CRLF, CR) #87

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Dec 30, 2024

@akaihola akaihola added the bug Something isn't working label Dec 30, 2024
@akaihola akaihola added this to the Darkgraylib 2.1.0 milestone Dec 30, 2024
@akaihola akaihola self-assigned this Dec 30, 2024
@akaihola akaihola marked this pull request as draft December 30, 2024 20:25
@akaihola
Copy link
Owner Author

akaihola commented Jan 3, 2025

@Carreau here's the fix on the Darkgraylib side to your bug report in akaihola/darker#768. I invited you as a collaborator on this repo, too – would you like to review?

@akaihola akaihola marked this pull request as ready for review January 3, 2025 15:58
@akaihola akaihola marked this pull request as draft January 3, 2025 16:18
@akaihola akaihola marked this pull request as ready for review January 3, 2025 16:32
Copy link
Collaborator

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Carreau
Copy link
Collaborator

Carreau commented Jan 6, 2025

Thanks ! I've fixed the upstream repo in IPython and it was really an edge case, but thenks for looking into it and fixing. Happy new year also.

@Carreau
Copy link
Collaborator

Carreau commented Jan 6, 2025

(I'm not sure about the policy here, but I think we can ignore the pyupgrade recommendation or just apply them, both are fine with me).

@akaihola akaihola merged commit b859b19 into main Jan 7, 2025
31 of 32 checks passed
@akaihola akaihola deleted the newline-splitting branch January 7, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

TextDocument splits lines on undesired characters
2 participants