-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation and refactor #7
Conversation
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Hi @ajtudela |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 96.44% 96.13% -0.32%
==========================================
Files 9 10 +1
Lines 788 724 -64
==========================================
- Hits 760 696 -64
Misses 28 28
|
That is because in your fork you have to maintain your main branch exactly as the upstream repo, in this case, as in my main branch. You have to make a new branch from your main with the feature you want to implement. Then, make a PR from that branch to my main branch. Once the PR is merged, you can sync your main branch. So, I'll close this PR. Make a new branch, cherrypick your new commits and make a new PR. Thanks 😉 |
Hi
It's me again 😄
I was working on translation and saw you've done the es part. The fr translation is in this MR.
There is also some refactor for entities (and tests updates for it).
Thanks