Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation and refactor #7

Closed
wants to merge 16 commits into from
Closed

Add translation and refactor #7

wants to merge 16 commits into from

Conversation

Delmael
Copy link

@Delmael Delmael commented Jan 16, 2025

Hi
It's me again 😄
I was working on translation and saw you've done the es part. The fr translation is in this MR.

There is also some refactor for entities (and tests updates for it).

Thanks

@Delmael Delmael marked this pull request as ready for review January 16, 2025 21:13
@Delmael
Copy link
Author

Delmael commented Jan 16, 2025

Hi @ajtudela
I don't know why there is so many commits but here some work.
Thanks

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (ded81c7) to head (21a3e10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   96.44%   96.13%   -0.32%     
==========================================
  Files           9       10       +1     
  Lines         788      724      -64     
==========================================
- Hits          760      696      -64     
  Misses         28       28              
Files with missing lines Coverage Δ
custom_components/smartbox/__init__.py 85.18% <100.00%> (ø)
custom_components/smartbox/climate.py 97.11% <100.00%> (-0.28%) ⬇️
custom_components/smartbox/config_flow.py 80.59% <100.00%> (-0.57%) ⬇️
custom_components/smartbox/entity.py 100.00% <100.00%> (ø)
custom_components/smartbox/model.py 98.90% <100.00%> (ø)
custom_components/smartbox/number.py 100.00% <100.00%> (ø)
custom_components/smartbox/sensor.py 98.96% <100.00%> (-0.24%) ⬇️
custom_components/smartbox/switch.py 100.00% <100.00%> (ø)

@ajtudela
Copy link
Owner

Hi @ajtudela
I don't know why there is so many commits but here some work.
Thanks

That is because in your fork you have to maintain your main branch exactly as the upstream repo, in this case, as in my main branch.

You have to make a new branch from your main with the feature you want to implement.

Then, make a PR from that branch to my main branch. Once the PR is merged, you can sync your main branch.

So, I'll close this PR. Make a new branch, cherrypick your new commits and make a new PR.

Thanks 😉

@ajtudela ajtudela closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants