Fix unsound bitmap buffers vec instead of a dropped vec's pointer #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my initial attempt at resolving the unsound bitmap buffer method (issue #174), quick and dirty. I'm using it locally in a fork, but this submission is just to give ideas about how you'd like this tackled.
The nice part is that there are method we can use to write code that works equally well on a &[u8] (from the native code path) and a Vec (from the wasm code path):
.as_ref()
on a&[u8]
and aVec<u8>
return the same thing:&[u8]
Vec::from(buffer)
works on both a&[u8]
andVec<u8>