Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test cases that are no longer valid with go 1.17 #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jawn-smith
Copy link

As of go 1.17, the net/http and net/url packages no longer accept ';' as a valid separator. See https://golang.org/doc/go1.17#semicolons for more information.

In order to build this package with go 1.17 and keep it in Ubuntu, the test cases that use ';' as a separator should be removed.

@jawn-smith
Copy link
Author

Actually, perhaps I should just change the ';' characters to '&' which is still a valid separator. Do the devs here have an opinion?

@jawn-smith
Copy link
Author

Actually, perhaps I should just change the ';' characters to '&' which is still a valid separator. Do the devs here have an opinion?

I went with this as it's a much smaller change that doesn't remove any test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant