Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited cpu limits for workflows #4181

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Edited cpu limits for workflows #4181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions k8s/workflows/values-stage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,28 @@ resources:
cpu: 125m
memory: 500Mi
limits:
cpu: 1000m
memory: 1500Mi
scheduler:
requests:
cpu: 125m
memory: 500Mi
limits:
cpu: 1000m
memory: 2000Mi
celery:
requests:
cpu: 125m
memory: 500Mi
limits:
cpu: 2500m
memory: 2000Mi
redis:
requests:
cpu: 50m
memory: 125Mi
limits:
cpu: 1000m
memory: 2000Mi
Comment on lines +44 to 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Optimize Redis resource allocation

The Redis instance has a high memory limit (2000Mi) and CPU limit (1000m) for what is typically a lightweight in-memory store.

Consider reducing the limits unless there's a specific requirement:

redis:
  requests:
    cpu: 250m
    memory: 500Mi
  limits:
    cpu: 500m
    memory: 1000Mi

This should be sufficient for most Redis workloads while maintaining good performance.

volumeMounts:
- name: config-volume
Expand Down
2 changes: 1 addition & 1 deletion src/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Workflows.
# Workflows

This folder contains functionality for running various AirQo workflow scripts using Apache Airflow framework, an open-source workflow management platform for data engineering pipelines.

Expand Down
Loading