Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to production #3731

Merged
merged 11 commits into from
Oct 22, 2024
Merged

move to production #3731

merged 11 commits into from
Oct 22, 2024

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Oct 22, 2024

@Baalmart Baalmart merged commit ee1694e into master Oct 22, 2024
11 checks passed
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 24.39024% with 124 lines in your changes missing coverage. Please review.

Project coverage is 11.69%. Comparing base (dffa902) to head (143b27e).
Report is 655 commits behind head on master.

Files with missing lines Patch % Lines
...rc/device-registry/validators/device.validators.js 33.89% 39 Missing ⚠️
src/device-registry/utils/create-event.js 0.00% 28 Missing ⚠️
src/device-registry/controllers/create-event.js 0.00% 17 Missing ⚠️
src/device-registry/middleware/common.js 17.64% 14 Missing ⚠️
src/device-registry/models/Reading.js 6.66% 14 Missing ⚠️
...ce-registry/middleware/validateOptionalObjectId.js 31.25% 11 Missing ⚠️
src/auth-service/bin/server.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3731   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files         110      110           
  Lines       14847    14847           
  Branches      274      274           
=======================================
  Hits         1737     1737           
  Misses      13110    13110           
Files with missing lines Coverage Δ
...e-registry/bin/jobs/v2-check-network-status-job.js 44.82% <100.00%> (ø)
src/device-registry/models/Device.js 14.50% <100.00%> (ø)
src/device-registry/models/Event.js 6.81% <100.00%> (ø)
src/device-registry/routes/v2/devices.js 100.00% <100.00%> (ø)
src/device-registry/routes/v2/readings.js 42.50% <100.00%> (ø)
src/auth-service/bin/server.js 11.11% <0.00%> (ø)
...ce-registry/middleware/validateOptionalObjectId.js 31.25% <31.25%> (ø)
src/device-registry/middleware/common.js 17.64% <17.64%> (ø)
src/device-registry/models/Reading.js 28.57% <6.66%> (ø)
src/device-registry/controllers/create-event.js 2.12% <0.00%> (ø)
... and 2 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants