Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to production #3719

Merged
merged 13 commits into from
Oct 21, 2024
Merged

move to production #3719

merged 13 commits into from
Oct 21, 2024

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Oct 21, 2024

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 34.56790% with 53 lines in your changes missing coverage. Please review.

Project coverage is 11.69%. Comparing base (d9ee6fd) to head (c56e52f).
Report is 639 commits behind head on master.

Files with missing lines Patch % Lines
...rc/device-registry/validators/device.validators.js 33.89% 39 Missing ⚠️
src/device-registry/middleware/common.js 17.64% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
+ Coverage   11.59%   11.69%   +0.10%     
==========================================
  Files         108      110       +2     
  Lines       14875    14847      -28     
  Branches      274      274              
==========================================
+ Hits         1725     1737      +12     
+ Misses      13150    13110      -40     
Files with missing lines Coverage Δ
src/device-registry/routes/v2/devices.js 100.00% <100.00%> (+73.22%) ⬆️
src/device-registry/middleware/common.js 17.64% <17.64%> (ø)
...rc/device-registry/validators/device.validators.js 33.89% <33.89%> (ø)

@Baalmart Baalmart merged commit 19e9002 into master Oct 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant