Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to production #3705

Merged
merged 24 commits into from
Oct 20, 2024
Merged

move to production #3705

merged 24 commits into from
Oct 20, 2024

Conversation

Baalmart and others added 20 commits October 17, 2024 00:48
Enhance Middleware to Support Validation of Optional Selected Sites as Array or Object
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 75 lines in your changes missing coverage. Please review.

Project coverage is 11.59%. Comparing base (1cc9d19) to head (c9289e1).
Report is 755 commits behind head on master.

Files with missing lines Patch % Lines
src/device-registry/utils/create-event.js 0.00% 28 Missing ⚠️
src/device-registry/controllers/create-event.js 0.00% 17 Missing ⚠️
src/device-registry/models/Reading.js 6.66% 14 Missing ⚠️
...ce-registry/middleware/validateOptionalObjectId.js 31.25% 11 Missing ⚠️
src/auth-service/bin/server.js 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3705       +/-   ##
===========================================
- Coverage   27.04%   11.59%   -15.46%     
===========================================
  Files         146      108       -38     
  Lines       21340    14871     -6469     
  Branches      274      274               
===========================================
- Hits         5772     1724     -4048     
+ Misses      15568    13147     -2421     
Files with missing lines Coverage Δ
src/device-registry/models/Event.js 6.81% <100.00%> (ø)
src/device-registry/routes/v2/readings.js 42.50% <100.00%> (+3.36%) ⬆️
src/auth-service/bin/server.js 11.11% <0.00%> (ø)
...ce-registry/middleware/validateOptionalObjectId.js 31.25% <31.25%> (ø)
src/device-registry/models/Reading.js 28.57% <6.66%> (-3.96%) ⬇️
src/device-registry/controllers/create-event.js 2.12% <0.00%> (-0.04%) ⬇️
src/device-registry/utils/create-event.js 3.57% <0.00%> (-11.53%) ⬇️

... and 62 files with indirect coverage changes

@Baalmart Baalmart merged commit ce887f9 into master Oct 20, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant