Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use dynamic publisher #3691

Merged

Conversation

NicholasTurner23
Copy link
Contributor

@NicholasTurner23 NicholasTurner23 commented Oct 19, 2024

Description

This PR implements the dynamic kafka consumer.

Summary by CodeRabbit

  • New Features
    • Introduced a new method for publishing data to Kafka topics, enhancing flexibility with message keys and partitioning.
  • Bug Fixes
    • Updated existing methods to utilize the new publishing logic, ensuring consistent data transmission.
  • Refactor
    • Improved the internal logic for data chunking and message sending for more efficient data transmission.

Copy link
Contributor

coderabbitai bot commented Oct 19, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces significant changes to the MessageBrokerUtils class within the src/workflows/airqo_etl_utils/message_broker_utils.py file. The primary modification involves replacing the private method __send_data with a new public method publish_to_topic, enhancing the flexibility of data publishing to Kafka topics. Additionally, the update_hourly_data_topic and update_hourly_data_topic_ methods have been updated to utilize this new method, ensuring improved handling of message keys and partitioning.

Changes

File Path Change Summary
src/workflows/airqo_etl_utils/message_broker_utils.py - Added method publish_to_topic for publishing data to Kafka with optional message keys and partitioning.
- Updated signatures for update_hourly_data_topic and update_hourly_data_topic_ to include return type annotations.
- Refactored methods to call publish_to_topic instead of __send_data.

Possibly related PRs

  • Update/kafka implementations [WIP] #3683: The changes in this PR also involve the MessageBrokerUtils class and include updates to the publish_to_topic method, which aligns with the refactoring of the data sending mechanism in the main PR.

Suggested reviewers

  • Mnoble-19
  • BenjaminSsempala
  • Psalmz777

🎉 In the land of code where messages flow,
A new method emerged, with a powerful glow.
publish_to_topic, so flexible and bright,
Sends data to Kafka, with keys shining light.
Refactored and polished, now better it seems,
In the world of ETL, we’re living the dreams! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Baalmart Baalmart merged commit b7c1b8e into airqo-platform:staging Oct 19, 2024
43 checks passed
@Baalmart Baalmart mentioned this pull request Oct 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants