Feat: session update account address and pbk #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of handling both the account address and its public key within the same
session_updateis to prevent afetchAccountscall, which can lead to undesired behaviors (as noted in issue #765).With the changes in #782, a wallet can send only the public key, allowing Beacon to resolve the account's address independently.
However, to ensure backward compatibility with previous Beacon versions, the changes introduced in this PR are beneficial. Developers can still send the account address in the first position of the accounts array and the public key in the second position, thereby avoiding the
fetchAccountscall.