Add react@19 to peer dependencies of all packages #1889
Merged
+53
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
lgtm, will do a pre-release of this. thanks again @darthmaim!
| @@ -122,6 +122,8 @@ | |||
| }, | |||
| "resolutions": { | |||
| "@babel/parser": "^7.15.3", | |||
| "handlebars": "4.5.3" | |||
| "handlebars": "4.5.3", | |||
| "react": "18.0.0", | |||
|
🎉 This PR is included in version |
|
🎉 This PR is included in version |
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
|| ^19.0.0-0to allreactandreact-dompeer dependencies.This still uses react@18 in this repo, since the tests don't yet support react 19 (see #1883 (comment)). I've had to use
18.0.0instead of the latest 18 release18.3.1, because some tests fail because of deprecation warnings with18.3.1and18.0.0was the version resolved by yarn before, so this doesn't change anything.Caution
I've only tested a few packages with react@19 so far, some of them might not work yet.