Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum uv version in pyproject.toml #6714

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Jan 16, 2025

This sets the minimum uv version pyproject.toml, which is needed to have a consistent lockfile.
When a dev has an outdated uv version, they'll get an error

❯ uv self update 0.5.19
info: Checking for updates...
success: Upgraded uv from v0.5.20 to v0.5.19! https://github.com/astral-sh/uv/releases/tag/0.5.19
❯ uv lock
error: Required version `>=0.5.20` does not match the running version `0.5.19`

Even better solution for a stable uv version will be to have it in enforced in a pre-commit hook, as in #6699, but that PR is blocked for now.

I've also pinned the setup-uv action to a specific version to prevent accidental regressions since that action is still undergoing heavy development. The new 5.2.0 also allows us to drop a VIRTUAL_ENV workaround. 🎉

Closes #6712

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (7387056) to head (1e05f3e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6714   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files         563      563           
  Lines       41766    41766           
=======================================
  Hits        32574    32574           
  Misses       9192     9192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas
Copy link
Collaborator Author

Great to see that all the tests now take less than 20 minutes, well done @unkcpz!

Copy link
Contributor

@khsrali khsrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielhollas LGTM!

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me as well, thanks.

@unkcpz unkcpz merged commit c88fc05 into aiidateam:main Jan 16, 2025
23 checks passed
@danielhollas danielhollas deleted the set-minimum-uv-version branch January 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails, despite uv file being updated
3 participants