Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: Async run #6708

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Engine: Async run #6708

merged 9 commits into from
Jan 16, 2025

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Jan 15, 2025

Engine Updates: Modifies engine to adopt with the recent changes in plumpy from v0.23.0 on.

This is part of the bigger PR #6626, separated as @unkcpz suggested,
which it's initial commits were pulled from #6079 (closed).

@khsrali khsrali requested a review from unkcpz January 15, 2025 09:59
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (b432611) to head (8ef54df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/engine/daemon/execmanager.py 91.67% 1 Missing ⚠️
src/aiida/engine/processes/calcjobs/tasks.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6708   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         563      563           
  Lines       41762    41762           
=======================================
  Hits        32570    32570           
  Misses       9192     9192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khsrali exactly what I was thinking. Neat implementation!

@khsrali khsrali merged commit d71ef98 into aiidateam:main Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants