CI: fix failed test_containerized.py integration test for containerized code #6707
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
fail-container-ci
branch
17 times, most recently
from
68cd23a to
3dce90e
Compare
unkcpz
force-pushed
the
fail-container-ci
branch
from
3dce90e to
a15d772
Compare
unkcpz
changed the title
unkcpz
force-pushed
the
fail-container-ci
branch
2 times, most recently
from
90cbba7 to
f548f6e
Compare
unkcpz
force-pushed
the
fail-container-ci
branch
from
c103b03 to
9ca39b6
Compare
unkcpz
force-pushed
the
fail-container-ci
branch
from
acd6a15 to
237de85
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6707 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 563 563
Lines 41762 41762
=======================================
Hits 32570 32570
Misses 9192 9192 ☔ View full report in Codecov by Sentry. |
danielhollas
approved these changes
Jan 16, 2025
| - name: Run daemon nightly tests | ||
| id: daemon-tests | ||
| run: source .venv/bin/activate && .github/workflows/daemon_tests.sh |
There was a problem hiding this comment.
Suggested change
| run: source .venv/bin/activate && .github/workflows/daemon_tests.sh | |
| run: .github/workflows/daemon_tests.sh |
I thing the venv is already activated by setup-uv action
| @@ -55,9 +55,6 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: eWaterCycle/setup-singularity@v7 # for containerized code test | |||
| with: | |||
| singularity-version: 3.8.7 | |||
|
|
|||
| - name: Install system dependencies | |||
| run: sudo apt update && sudo apt install postgresql | |||
There was a problem hiding this comment.
I wonder if we should be installing graphviz here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6709
The test is run in nightly.yml as integration test for running containerized code.
The problem may because the new ubuntu don't allow the container to get root permission even for singularity. Since singularity is anyway outdated and we support docker as containerized code engine. I change it to use docker to run the code from a image.
This also remove the CI action (which has no maintains for around 2 years) of building singularity.