Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only emit path to daemon log path in pytest tmp folder #6698

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 10, 2025

When working with daemon, fixture started_daemon_worker will start daemon through circus and writing logs to the log file stay in the pytest tmp folder.
It is not straightforward to find where the log file is to check the daemon log that related to the hang engine tests.
The PR write a log in debug level to print the location of the daemon log.

@unkcpz unkcpz requested a review from agoscinski January 10, 2025 14:35
@unkcpz unkcpz force-pushed the emit-debug-log-showing-daemon-log-path branch from 6983ad3 to 0645fd5 Compare January 10, 2025 14:37
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (b432611) to head (dfbd544).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/tools/pytest_fixtures/daemon.py 83.34% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6698      +/-   ##
==========================================
- Coverage   77.99%   76.56%   -1.43%     
==========================================
  Files         563      563              
  Lines       41762    41766       +4     
==========================================
- Hits        32570    31975     -595     
- Misses       9192     9791     +599     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz force-pushed the emit-debug-log-showing-daemon-log-path branch 2 times, most recently from 02ce02c to 5893ff4 Compare January 13, 2025 23:50
Copy link
Contributor

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested implementation and it worked.

@unkcpz unkcpz force-pushed the emit-debug-log-showing-daemon-log-path branch from 5893ff4 to 7a328a7 Compare January 16, 2025 09:24
@unkcpz unkcpz merged commit 7a460c0 into aiidateam:main Jan 16, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants