Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: quick fix on benchmark CI using uv run pytest #6651

Closed
wants to merge 2 commits into from
Closed

CI: quick fix on benchmark CI using uv run pytest #6651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4230b64
CI: quick fix on benchmark CI using uv run pytest
unkcpz Dec 5, 2024
9f4e019
Merge branch 'main' into quick-fix-benchmark-ci-fail
unkcpz Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
branches: [main]
paths-ignore: [docs/**]
pull_request:
branches-ignore: [gh-pages]
paths: [.github/workflows/benchmark*]

# https://docs.github.com/en/actions/using-jobs/using-concurrency
concurrency:
Expand Down Expand Up @@ -54,9 +57,10 @@ jobs:
uses: ./.github/actions/install-aiida-core
with:
python-version: '3.10'
from-lock: 'true'

- name: Run benchmarks
run: pytest --db-backend psql --benchmark-only --benchmark-json benchmark.json tests/
run: uv run pytest --db-backend psql --benchmark-only --benchmark-json benchmark.json tests/

- name: Store benchmark result
uses: aiidateam/github-action-benchmark@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unkcpz can you open this PR from origin? It looks like the store step is failing, likely due to permission issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix btw! Definitely forgot a few spots.

Expand Down
Loading