Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddingTagsEditor Bug #574

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix AddingTagsEditor Bug #574

merged 1 commit into from
Nov 30, 2023

Conversation

AndresOrtegaGuerrero
Copy link
Member

This fix the bug reported previously in #541 , somehow it returned

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (09ba7d0) 80.73% compared to head (86c835c) 80.73%.

Files Patch % Lines
src/aiidalab_qe/common/widgets.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          49       49           
  Lines        3415     3415           
=======================================
  Hits         2757     2757           
  Misses        658      658           
Flag Coverage Δ
python-3.10 80.73% <0.00%> (ø)
python-3.8 80.77% <0.00%> (ø)
python-3.9 80.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. thanks!

@unkcpz unkcpz merged commit 0cc35b9 into main Nov 30, 2023
15 of 17 checks passed
@unkcpz unkcpz deleted the fix/bug_tags_editor branch November 30, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants