Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download AiiDA data notebook #1065

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

edan-bainglass
Copy link
Member

This PR updates the download AiiDA data notebook w.r.t changes in the download widget.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (72911d9) to head (184547f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files         112      112           
  Lines        6668     6668           
=======================================
  Hits         4526     4526           
  Misses       2142     2142           
Flag Coverage Δ
python-3.11 67.87% <ø> (+0.01%) ⬆️
python-3.9 67.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndresOrtegaGuerrero
Copy link
Member

image
My test is working fine! thanks!

@edan-bainglass
Copy link
Member Author

image My test is working fine! thanks!

@AndresOrtegaGuerrero good enough to approve then? 😅🙏

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! , thank you @edan-bainglass

@edan-bainglass edan-bainglass merged commit 084431f into aiidalab:main Jan 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants