-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #646 from aiarena/chore/speed-up-elo-recalc
Speed up the elo recalc command by removing transaction usage
- Loading branch information
Showing
1 changed file
with
62 additions
and
61 deletions.
There are no files selected for viewing
123 changes: 62 additions & 61 deletions
123
aiarena/core/management/commands/recalculatecompetitionelos.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,74 @@ | ||
| from django.core.management.base import BaseCommand | ||
| from django.db import transaction, connection | ||
|
|
||
| from aiarena.core.models import Match, Competition, CompetitionParticipation, Round, MatchParticipation, Result | ||
| from aiarena.core.models import Match, Competition, CompetitionParticipation, MatchParticipation | ||
| from aiarena.settings import ELO_START_VALUE | ||
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| help = 'Recalculates a competition\'s ELOs based on all matches for that competition. This can take a VERY long time. ' \ | ||
| 'WARNING! Nothing else should attempt to modify the database while this runs.' | ||
| help = ('Recalculates a competition\'s ELOs based on all matches for that competition. ' | ||
| 'This can take a VERY long time. ' | ||
| 'WARNING: This is not protected by a lock or transaction. ' \ | ||
| 'Ensure no other processes are affecting this competition while this job runs.' ) | ||
|
|
||
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument('competition_id', type=int, help="The competition to recalculate.") | ||
|
|
||
| def handle(self, *args, **options): | ||
| self.stdout.write(f"Starting ELO re-calculation for competition id {options['competition_id']}...") | ||
| with transaction.atomic(): | ||
| self.stdout.write(f"Locking records...") | ||
| target_competition = Competition.objects.select_for_update().get(id=options['competition_id']) | ||
| self.stdout.write(f"Competition id {target_competition.id} locked.") | ||
| competition_participants = CompetitionParticipation.objects.select_for_update().filter(competition=target_competition) | ||
| self.stdout.write(f"{competition_participants.count()} competition participants locked.") | ||
| matches = Match.objects.select_for_update().filter(round__competition=target_competition, result__isnull=False)\ | ||
| .prefetch_related('matchparticipation_set', 'result').order_by('result__created') | ||
|
|
||
| self.stdout.write(f"{matches.count()} matches locked.") | ||
|
|
||
| self.stdout.write(f"Resetting all ELOs to starting ELO...", ending='\r') | ||
| for participant in competition_participants: | ||
| participant.elo = ELO_START_VALUE | ||
| participant.save() | ||
| self.stdout.write(f"Resetting all ELOs to starting ELO...done") | ||
|
|
||
| self.stdout.write(f"Recalculating all match ELOs...0%", ending='\r') | ||
| count: int = 0 | ||
| for match in matches: | ||
| count += 1 | ||
| p1: MatchParticipation = match.participant1 | ||
| p2: MatchParticipation = match.participant2 | ||
|
|
||
| # Starting ELO | ||
| p1.starting_elo = p1.competition_participant.elo | ||
| p2.starting_elo = p2.competition_participant.elo | ||
| initial_elo_sum = p1.starting_elo + p2.starting_elo | ||
|
|
||
| match.result.adjust_elo() | ||
| p1.competition_participant.refresh_from_db() | ||
| p2.competition_participant.refresh_from_db() | ||
|
|
||
| # Resultant ELO | ||
| p1.resultant_elo = p1.competition_participant.elo | ||
| p2.resultant_elo = p2.competition_participant.elo | ||
| resultant_elo_sum = p1.resultant_elo + p2.resultant_elo | ||
|
|
||
| # ELO change | ||
| p1.elo_change = p1.resultant_elo - p1.starting_elo | ||
| p2.elo_change = p2.resultant_elo - p2.starting_elo | ||
|
|
||
| p1.save() | ||
| p2.save() | ||
|
|
||
| if initial_elo_sum != resultant_elo_sum: | ||
| self.stdout.write(f"ERROR: Initial and resultant ELO sum mismatch: " | ||
| f"Match {match.id}. " | ||
| f"initial_elo_sum: {initial_elo_sum}. " | ||
| f"resultant_elo_sum: {resultant_elo_sum}. " | ||
| f"participant1.elo_change: {p1.elo_change}. " | ||
| f"participant2.elo_change: {p2.elo_change}") | ||
|
|
||
| self.stdout.write(f"Recalculating all match ELOs...{count/matches.count()*100}%", ending='\r') | ||
|
|
||
| self.stdout.write(f"Recalculating all match ELOs...done") | ||
| self.stdout.write(f"Job finished!") | ||
|
|
||
| target_competition = Competition.objects.get(id=options['competition_id']) | ||
| self.stdout.write(f"Competition id {target_competition.id} located.") | ||
| competition_participants = CompetitionParticipation.objects.filter(competition=target_competition) | ||
| self.stdout.write(f"{competition_participants.count()} competition participants located.") | ||
| matches = Match.objects.filter(round__competition=target_competition, result__isnull=False)\ | ||
| .prefetch_related('matchparticipation_set', 'result').order_by('result__created') | ||
|
|
||
| self.stdout.write(f"{matches.count()} matches located.") | ||
|
|
||
| self.stdout.write(f"Resetting all ELOs to starting ELO...", ending='\r') | ||
| for participant in competition_participants: | ||
| participant.elo = ELO_START_VALUE | ||
| participant.save() | ||
| self.stdout.write(f"Resetting all ELOs to starting ELO...done") | ||
|
|
||
| self.stdout.write(f"Recalculating all match ELOs...0%", ending='\r') | ||
| count: int = 0 | ||
| for match in matches: | ||
| count += 1 | ||
| p1: MatchParticipation = match.participant1 | ||
| p2: MatchParticipation = match.participant2 | ||
|
|
||
| # Starting ELO | ||
| p1_starting_elo = p1.competition_participant.elo | ||
| p2_starting_elo = p2.competition_participant.elo | ||
| initial_elo_sum = p1_starting_elo + p2_starting_elo | ||
|
|
||
| match.result.adjust_elo() | ||
| p1.competition_participant.refresh_from_db() | ||
| p2.competition_participant.refresh_from_db() | ||
|
|
||
| # Resultant ELO | ||
| p1.resultant_elo = p1.competition_participant.elo | ||
| p2.resultant_elo = p2.competition_participant.elo | ||
| resultant_elo_sum = p1.resultant_elo + p2.resultant_elo | ||
|
|
||
| # ELO change | ||
| p1.elo_change = p1.resultant_elo - p1_starting_elo | ||
| p2.elo_change = p2.resultant_elo - p2_starting_elo | ||
|
|
||
| p1.save() | ||
| p2.save() | ||
|
|
||
| if initial_elo_sum != resultant_elo_sum: | ||
| self.stdout.write(f"ERROR: Initial and resultant ELO sum mismatch: " | ||
| f"Match {match.id}. " | ||
| f"initial_elo_sum: {initial_elo_sum}. " | ||
| f"resultant_elo_sum: {resultant_elo_sum}. " | ||
| f"participant1.elo_change: {p1.elo_change}. " | ||
| f"participant2.elo_change: {p2.elo_change}") | ||
|
|
||
| self.stdout.write(f"Recalculating all match ELOs...{count/matches.count()*100}%", ending='\r') | ||
|
|
||
| self.stdout.write(f"Recalculating all match ELOs...done") | ||
| self.stdout.write(f"Job finished!") |