refactor(approval): pR approvals can be done with one api call

ahmadnassri · Aug 25, 2020 · 1da24bb · 1da24bb
1 parent 8a0c0f9
commit 1da24bb
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/action/lib/api.js b/action/lib/api.js
@@ -1,14 +1,8 @@
 export async function approve (octokit, repo, { number }) {
-  const { data: { id } } = await octokit.pulls.createReview({
-    ...repo,
-    pull_number: number
-  })
-
-  await octokit.pulls.submitReview({
+  await octokit.pulls.createReview({
     ...repo,
     pull_number: number,
-    event: 'APPROVE',
-    review_id: id
+    event: 'APPROVE'
   })
 }