-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept bytes for Unix socket paths. #640
Conversation
While this is almost an annotations only patch, it does replace the use of |
What would that actually be testing? It's just passed straight through to the underlying socket. |
It would test that a bytes-based socket path would not result in |
It's even clearer now that I tried:
|
Also added bytes supports for the other methods and added tests for each distinct one. I had to duplicate a bit of logic from Pathlib around stat()ing. |
Also please add a changelog entry in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
*nix paths are an arbitrary sequence of bytes.