forked from Polymer/shop
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials payment #1
Merged
agektmr
merged 14 commits into
agektmr:credential-payment
from
afitz0:credentials-payment
Nov 7, 2016
Merged
Credentials payment #1
agektmr
merged 14 commits into
agektmr:credential-payment
from
afitz0:credentials-payment
Nov 7, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features included are: * 'Buy Now' button added to detail pages when PaymentRequest (PR) is available. * All checkout buttons (e.g., from added-to-cart modal and on /cart) now check for PR and fire if available. * /checkout checks for PR on load and fires if available * Shipping options demonstrate having different options for different locations, including declining to ship outside of US.
1. When user taps "buy now" from item detail 2. When user tries to check out (cart was being erroneously re-initialized)
* Move shop-payment-request to lazy import * Shortend supported payment list (full list set as default) * Declare process-payment event as coming from shop-payment-request
* `shop-payment-request` is a bit more general now (e.g., by decoupling it from the cart's structure and the logic around "Buy Now" vs. "Buy Cart") * `_redirectToCheckout` in `shop-payment-request` no longer causes an app reload. * `shop-payment-request` fires coded `error` events on failure, and redirects for _all_ errors except `Request Cancelled`
…into credentials-payment
agektmr
approved these changes
Nov 7, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from Polymer#70 into Polymer#91