Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials payment #1

Merged
merged 14 commits into from
Nov 7, 2016

Conversation

afitz0
Copy link

@afitz0 afitz0 commented Nov 7, 2016

Merge changes from Polymer#70 into Polymer#91

Andrew Fitz Gibbon added 14 commits August 26, 2016 14:44
Features included are:
* 'Buy Now' button added to detail pages when PaymentRequest (PR) is available.
* All checkout buttons (e.g., from added-to-cart modal and on /cart) now check for PR and fire if available.
* /checkout checks for PR on load and fires if available
* Shipping options demonstrate having different options for different locations, including declining to ship outside of US.
1. When user taps "buy now" from item detail
2. When user tries to check out (cart was being erroneously re-initialized)
* Move shop-payment-request to lazy import
* Shortend supported payment list (full list set as default)
* Declare process-payment event as coming from shop-payment-request
* `shop-payment-request` is a bit more general now (e.g., by decoupling it from the cart's structure and the logic around "Buy Now" vs. "Buy Cart")
* `_redirectToCheckout` in `shop-payment-request` no longer causes an app reload.
* `shop-payment-request` fires coded `error` events on failure, and redirects for _all_ errors except `Request Cancelled`
Copy link
Owner

@agektmr agektmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agektmr agektmr merged commit d58bdcf into agektmr:credential-payment Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants