Simplify (and generalize) invElPropElimN
#1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - looks good to me. Maybe @mzeuner has something to say as well. |
|
Amazing, I don't know how I convinced myself that |
|
Ok, thanks. I hope it is ok if I merge this myself then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly simplifies the proof of
invElPropElimNinCubical/Algebra/CommRing/Localisation/InvertingElements.agdaand drops the unnecessary restriction to positive numbers (suc n).This slightly simplifies two other things as well:
suc nbynin the whole fileCubical/Algebra/CommRing/Localisation/Limit.agda.isSheaf𝓞ᴮinCubical/Algebra/ZariskiLattice/StructureSheaf.agda.Disclaimer: I did not read/understand all of the code in which I replaced
(suc n)withn. :-) But it only makes all statements stronger as far as I can see.[I found this potential for improvement while reviewing #1086, and that PR will also be slightly simplified by the changes proposed here.]