opaque
instead of abstract
in QuotientAlgebra
#1078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts using the
opaque
feature of Agda 2.6.4 in the cubical library. Namely, it replaces the oldabstract
keyword inQuotientAlgebra.agda
(where it was used to keep type checking times reasonable) with the newopaque
/unfolding
mechanism. I think the result is much cleaner and more readable than the old hugeabstract
block. (And also we could now use named modules again if we wanted!)The transformation was straight-forward, none of the actual definitions had to be changed at all. (I only had to indent them one more level...)
I made a separate
opaque
block for every definition. This is I think recommendable because the way that definitions in the sameopaque
block can only be unfolded together can be confusing.I am planning to do the same in
FPAlgebra.agda
, but thought it is good to start with small steps. :-)