Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opaque instead of abstract in QuotientAlgebra #1078

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

MatthiasHu
Copy link
Contributor

This PR starts using the opaque feature of Agda 2.6.4 in the cubical library. Namely, it replaces the old abstract keyword in QuotientAlgebra.agda (where it was used to keep type checking times reasonable) with the new opaque/unfolding mechanism. I think the result is much cleaner and more readable than the old huge abstract block. (And also we could now use named modules again if we wanted!)

The transformation was straight-forward, none of the actual definitions had to be changed at all. (I only had to indent them one more level...)

I made a separate opaque block for every definition. This is I think recommendable because the way that definitions in the same opaque block can only be unfolded together can be confusing.

I am planning to do the same in FPAlgebra.agda, but thought it is good to start with small steps. :-)

@felixwellen
Copy link
Collaborator

Yes, it is good to start with small steps!
Looks good to me -> merging.

@felixwellen felixwellen merged commit 3b2a50a into agda:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants