-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check all agda files #1058
Check all agda files #1058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files should be kept IMO and some I don't know if we should throw out or not
Maybe I should add: I don't actually if all of them don't check. After a couple of them failed, I just removed everything not in |
Ok, I think it would be better to check which check and then add them to Everything. Then we can decide whether we fix the broken ones or not |
Ps: it would be good not to have a manually written Everything file. It's very easy to forget to add new files |
Yes, absolutely. We shouldn't have done that ;-) |
Also note that we have more manually maintained
I guess the otheres might be more unlikely to lead to issues, since the stuff in those folders is likely to be used elsewhere. If there are files that don't check, I should have seen it by now. |
I don't know either. Feel free to figure out which check and then we can decide what to do about those that don't, and eventually get rid of gen-except... |
b029df7
to
fdbb7e2
Compare
Some of the manual |
Core, Foundation, Codata all have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if @aljungstrom responds by tomorrow, otherwise you can merge. It seems silly to keep completely commented files though...
There are still some out-commented parts of files, but I think the situation is still a lot better than before, so I'll merge. |
fbf7623
to
5ae9985
Compare
(...after the rebase checks out) |
No description provided.