Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master reg #1864

Merged
merged 109 commits into from
Jan 7, 2025
Merged

Merge master reg #1864

merged 109 commits into from
Jan 7, 2025

Conversation

jreidinger
Copy link
Contributor

merge master and solve conflicts

imobachgs and others added 30 commits December 12, 2024 11:32
Technically there it is not encryption (because the decryption is missing)
but hashing. That's the correct term.
Because it fails after updating to TypeDoc 0.27.4 and it was introduced
for a purpose that for now it is not currently being used. Thus, let's
postpone its usage until really needed if it is updated to work with the
lastest TypeDoc when such a moment arrive.

See,

  * Agama commit in which it was added  5e09032
  * Issue at upstream asgerjensen/typedoc-plugin-external-module-map#27
There were few core/Section leftover in storage namespace. Since
core/Section is going to be removed, Page.Section has been used
instead.
It was no longer needed and making TypeDoc to exit with an unexpected
error.
- As discussed on the review meeting, technically it is not an
encryption (because the decryption part is missing) but hashing. That's
the correct term.

## Testing

- Updated unit tests
- Tested manually

```console
# agama config show | jq .user
{
  "fullName": "Agama",
  "userName": "agama",
  "password": "$5$t3gRfqthxk7ZsJw.$gpduJASf12Xk8aPtIllniJAwhbhlYvLcEUH0.4P9MWA",
  "hashedPassword": true,
  "autologin": false
}
```
- To have a clean git checkout after running `cargo xtask openapi`
Those that were causing TypeDoc crashes, as described in commit
791857a.
Note that some eslint-disable @typescript-eslint/no-explicit-any has
been added. This should be temporary until the new storage part is
finished and these any can be replaced with more sensible types.
Agama-weblate commit: 39728aa29b413333ae13d33360e9beae230f3033
Agama-weblate commit: 39728aa29b413333ae13d33360e9beae230f3033
Agama-weblate commit: 39728aa29b413333ae13d33360e9beae230f3033
Updating the product translations from the agama-weblate repository
Updating the web translation files from the agama-weblate repository
Updating the service translation files from the agama-weblate repository
# Problem

After updating to TypeDoc 0.27, the `npm run typedoc` task stop working
because problems when loading `typedoc-plugin-external-module-map`. See
https://github.com/agama-project/agama/actions/runs/12302232612/job/34334622800

## Solution

Open an [issue in
upstream](asgerjensen/typedoc-plugin-external-module-map#27)
and stop using the conflicting plugin, fix all TypeDoc issues (see next
section), and revert commit d946480
added at #1225

## Additional work

Even without the mentioned plugin, TypeDoc tasks still failing because
other crash already mentioned in the commit message of
791857a

> TypeError: Cannot read properties of undefined (reading 'kindOf')
> at
/home/runner/work/agama/agama/web/node_modules/typedoc/dist/lib/models/types.js:687:63

Migrating some components to TypeScript solved the issue. This was done
at commit
34bc000,
which also includes adjustments needed after these migrations.
Fix for
[bsc#1234362](https://bugzilla.suse.com/show_bug.cgi?id=1234362). It
should unblock QA.

It fixes the behavior when importing an auto-installation profile:

* Follow redirections.
* Determine the file format from the content instead of the extension.
It does not apply to AutoYaST profiles, where it still uses the
extension in the URL for backward compatibility.

## Follow-up

The `agama profile import` command was not updated after adding the
`--api` switch. Therefore, if you try to import a profile from a remote
system, the profile will be processed on your machine (not in the remote
one). Among other potential problems, it will use hardware information
from the wrong system.

We need to move the logic to preprocess the profile from `agama-cli` to
`agama-server`.
dgdavid and others added 25 commits December 27, 2024 15:13
Agama-weblate commit: fccd059f5a372d063f8fd431fb98b8edc58db734
Updating the service translation files from the agama-weblate repository
Because it's no longer use.
Back in [July](#1456), it was
decided to start using TypeScript in the Agama web client, migrating the
existing codebase as files were updated. However, some files haven't
been touched in a while and is unlikely to change soon.

The proposal of this PR is to move such a migration forward by
converting almost all `.js` and `.jsx` files to TypeScript, except those
that are either:

* Candidates to be dropped in the short term, or
* Files under the storage namespace, which may conflict with ongoing
work tracked at
https://github.com/agama-project/agama/tree/storage-config-ui
## Problem

The description of the product SLES for SAP 16 is the same as for the
product SLES 16
see https://bugzilla.suse.com/show_bug.cgi?id=1235023

## Solution

Changed the description for product SLES for SAP 16 after discussion
with PM.

Not sure about the part with the translation. Please drop me a note if
anything is missing.
…nknonw

The registration attribute is actually mandatory, but better to prevent
displaying the alert if it is missing for some reason.
@dgdavid dgdavid merged commit 52f4da9 into product-registration Jan 7, 2025
6 checks passed
@dgdavid dgdavid deleted the merge_master_reg branch January 7, 2025 10:53
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
imobachgs added a commit that referenced this pull request Jan 13, 2025
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants