Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix third party imports using optional import block in agent contrib files #585

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Fix third party imports using optional import block in agent contrib files #585

merged 10 commits into from
Jan 21, 2025

Conversation

kumaranvpl
Copy link
Collaborator

Why are these changes needed?

Related issue number

Closes #553, #580, #584

Checks

@kumaranvpl kumaranvpl requested a review from davorrunje January 21, 2025 16:02
@kumaranvpl kumaranvpl marked this pull request as draft January 21, 2025 16:02
@kumaranvpl kumaranvpl marked this pull request as ready for review January 21, 2025 18:40
@davorrunje davorrunje added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 4605ead Jan 21, 2025
236 checks passed
@davorrunje davorrunje deleted the fix-imports-in-contrib branch January 21, 2025 21:40
This was referenced Jan 22, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use optional_import_block instead of try except block in tests
2 participants
@kumaranvpl @davorrunje