-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Gemini tool calling (plus general fixes) #18
Conversation
@marklysze there are conflicts. Could you fix the conflicts in this PR or draft a new PR? Thank you! |
@marklysze I have found a few minor issues when testing it with VertexAI using some of my own tests. I would still have to go through your tests. Should I prepare a PR to your branch for the suggested (minor) changes to support VertexAI as well? |
Thanks for that @luxzoli! It would be great if you could work on this branch. Let me update the branch in line with main now. |
@luxzoli, would you be on Discord as well? If so, can you let me know your Discord ID? If you want to message me on there, my Discord ID is |
Signed-off-by: Mark Sze <[email protected]>
Signed-off-by: Mark Sze <[email protected]>
Thanks @luxzoli, branch is updated, let me know how you go :) |
@marklysze could you fix the conflicts? Thank you! |
Signed-off-by: Mark Sze <[email protected]>
Hi @luxzoli, I'll merge this one as we're due for a release, if there are VertexAI changes or other fixes, can you please create a new PR? |
Sure! Nevertheless, yesterday I have tested the function calling again with VertexAI, and my original fix is not needed anymore 🙂 |
Why are these changes needed?
The Gemini class doesn't currently support tool calling.
This PR adds tool calling.
Additional updates:
NOTE: This hasn't been tested with Vertex AI authentication, if someone can test it that would be good. Please try the client test files in my repo.
Related issue number
Noted in Discord issue
Checks