Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gemini tool calling (plus general fixes) #18

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

marklysze
Copy link
Collaborator

Why are these changes needed?

The Gemini class doesn't currently support tool calling.

This PR adds tool calling.

Additional updates:

  • Removal of role alternation, this no longer appears necessary
  • Image input corrected for non-Vertex AI
  • Costs updated

NOTE: This hasn't been tested with Vertex AI authentication, if someone can test it that would be good. Please try the client test files in my repo.

Related issue number

Noted in Discord issue

Checks

@qingyun-wu
Copy link
Collaborator

@marklysze there are conflicts. Could you fix the conflicts in this PR or draft a new PR? Thank you!

@luxzoli
Copy link
Collaborator

luxzoli commented Dec 1, 2024

@marklysze I have found a few minor issues when testing it with VertexAI using some of my own tests. I would still have to go through your tests. Should I prepare a PR to your branch for the suggested (minor) changes to support VertexAI as well?

@marklysze
Copy link
Collaborator Author

@marklysze I have found a few minor issues when testing it with VertexAI using some of my own tests. I would still have to go through your tests. Should I prepare a PR to your branch for the suggested (minor) changes to support VertexAI as well?

Thanks for that @luxzoli! It would be great if you could work on this branch.

Let me update the branch in line with main now.

@marklysze
Copy link
Collaborator Author

@luxzoli, would you be on Discord as well? If so, can you let me know your Discord ID? If you want to message me on there, my Discord ID is msze_

@marklysze
Copy link
Collaborator Author

Thanks @luxzoli, branch is updated, let me know how you go :)

@qingyun-wu
Copy link
Collaborator

@marklysze could you fix the conflicts? Thank you!

@marklysze
Copy link
Collaborator Author

@marklysze I have found a few minor issues when testing it with VertexAI using some of my own tests. I would still have to go through your tests. Should I prepare a PR to your branch for the suggested (minor) changes to support VertexAI as well?

Hi @luxzoli, I'll merge this one as we're due for a release, if there are VertexAI changes or other fixes, can you please create a new PR?

@marklysze marklysze added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit fd0112e Dec 11, 2024
214 checks passed
@luxzoli
Copy link
Collaborator

luxzoli commented Dec 18, 2024

@marklysze I have found a few minor issues when testing it with VertexAI using some of my own tests. I would still have to go through your tests. Should I prepare a PR to your branch for the suggested (minor) changes to support VertexAI as well?

Hi @luxzoli, I'll merge this one as we're due for a release, if there are VertexAI changes or other fixes, can you please create a new PR?

Sure! Nevertheless, yesterday I have tested the function calling again with VertexAI, and my original fix is not needed anymore 🙂
For other things I will create a new PR then

davorrunje pushed a commit that referenced this pull request Dec 19, 2024
@kumaranvpl kumaranvpl deleted the geminitoolcalling branch January 30, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants