AG-12936 Fix zoom on bar series with only one series #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsjroberts
force-pushed
the
AG-12936-zoom-min-vis-bar-series
branch
2 times, most recently
from
9c4e55e to
79615e9
Compare
alantreadway
reviewed
Feb 6, 2025
| @@ -848,7 +848,9 @@ export abstract class CartesianSeries< | |||
| if (!dataModel || !processedData) return Infinity; | |||
|
|
|||
| const crossValues = this.keysOrValues(crossAxisKey); | |||
| const allAxisValues = axisKeys.map((axisKey) => this.keysOrValues(axisKey)); | |||
| const allAxisValues = axisKeys.map( | |||
| (axisKey) => processedData.columns[dataModel.resolveProcessedDataIndexById(this, axisKey)] ?? [] | |||
There was a problem hiding this comment.
Nit: Maybe use dataModel.resolveColumnById()?
There was a problem hiding this comment.
That's the one, forgot which fn it was that I used previously.
lsjroberts
force-pushed
the
AG-12936-zoom-min-vis-bar-series
branch
from
79615e9 to
7a87c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-12936