AG-11705 Update css variables hierarchy with theme params #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
from
c37b2d8 to
cf4c790
Compare
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
from
cf4c790 to
6c8e05b
Compare
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
3 times, most recently
from
6f699ae to
2cac269
Compare
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
from
2cac269 to
8da600f
Compare
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
from
8da600f to
7a18092
Compare
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
2 times, most recently
from
175d471 to
3ebf0aa
Compare
- Adds accentColor, spacing and chrome theme params. - Updates css theme variables to inherit from the theme params and removes unnecessary indirection/inheritance. - Pushes some variables into their local context where they did not need to be global. - Fixes inconsistent colours across context menu, dialogs and other popovers.
lsjroberts
force-pushed
the
AG-11705-theme-params-defaults
branch
from
3ebf0aa to
796f7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-11705
accentColor,spacingand chrome theme params.