Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AG-11705 Add textColor and subtleTextColor params with color mixing #3443

Merged
merged 5 commits into from
Jan 31, 2025
Merged

AG-11705 Add textColor and subtleTextColor params with color mixing #3443

merged 5 commits into from
Jan 31, 2025

Conversation

lsjroberts
Copy link
Member

@lsjroberts lsjroberts force-pushed the AG-11705-theme-params-defaults branch 4 times, most recently from 7ac70ea to ac8a752 Compare January 30, 2025 13:34
@lsjroberts lsjroberts force-pushed the AG-11705-theme-params-defaults branch 3 times, most recently from a2f6afe to 2116b95 Compare January 30, 2025 15:15
@lsjroberts lsjroberts force-pushed the AG-11705-theme-params-defaults branch from 2116b95 to 5f5a141 Compare January 30, 2025 15:51
@lsjroberts lsjroberts marked this pull request as ready for review January 30, 2025 15:51
@lsjroberts lsjroberts requested review from alantreadway and a team as code owners January 30, 2025 15:51
lsjroberts
lsjroberts commented Jan 31, 2025
View reviewed changes
packages/ag-charts-community/src/module/optionsModule.ts Outdated
@@ -269,6 +270,7 @@ export class ChartOptions<T extends AgChartOptions = AgChartOptions> {
processedOptions = deepClone(processedOptions, ChartOptions.OPTIONS_CLONE_OPTS);

const themeParameters = this.getThemeParameters(activeTheme, processedOptions);
this.resolveThemeOperations(themeParameters, themeParameters as any);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to fix this typing, will do before merge.

alantreadway
alantreadway reviewed Jan 31, 2025
View reviewed changes
packages/ag-charts-types/src/chart/themeOptions.ts Outdated
@@ -97,6 +97,18 @@ export interface AgChartThemeParams {
gridLineColor?: CssColor;
/** The outer chart padding. */
padding?: PixelSize;
/**
* TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Dangling TODOs?

alantreadway
alantreadway approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge after addressing your comments + my nit?

@lsjroberts lsjroberts merged commit 1eec7b2 into latest Jan 31, 2025
26 checks passed
@lsjroberts lsjroberts deleted the AG-11705-theme-params-defaults branch January 31, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alantreadway alantreadway alantreadway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsjroberts @alantreadway